[Json] Support FixedSizeList in json decoder - #9715
Merged
Merged
Conversation
liamzwbao
force-pushed
the
issue-9714-fixed-size-list-decoder
branch
from
April 14, 2026 15:53
58a95fc to
9ed71fc
Compare
liamzwbao
marked this pull request as ready for review
April 14, 2026 15:53
Jefffrey
approved these changes
Apr 19, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
There's a fun little degenerate test case here:
#[test]
fn test_fixed_size_list_zero_size() {
let buf = r#"
{"a": []}
{"a": null}
{"a": []}
"#;
let field = Field::new_list_field(DataType::Int32, true);
let schema = Arc::new(Schema::new(vec![Field::new(
"a",
DataType::FixedSizeList(Arc::new(field), 0),
false,
)]));
let batches = do_read(buf, 1024, false, false, schema);
assert_eq!(batches.len(), 1);
let col = batches[0].column(0).as_fixed_size_list();
assert_eq!(col.len(), 3);
assert_eq!(col.value_length(), 0);
let values = col.values().as_primitive::<Int32Type>();
assert!(values.values().is_empty());
}It seems to panic within struct array decoding. Could be worth exploring in this PR if there is capacity, though considering this PR is adding a new feature I wouldn't block it on this case.
|
|
||
| let mut nulls = self | ||
| .is_nullable | ||
| .then(|| BooleanBufferBuilder::new(pos.len())); |
Contributor
There was a problem hiding this comment.
Is it worth considering using NullBufferBuilder here instead?
Contributor
There was a problem hiding this comment.
Filed a ticket to track
Contributor
Filed a ticket to track |
Contributor
|
Thank you @liamzwbao and @Jefffrey |
Contributor
Author
Contributor
|
Thank you ! I was trying to finalize the release content and keep things moving. |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#9714. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Implement decoder for FixedSizeList # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> New decoding type supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FixedSizeListin arrow-json reader #9714.Rationale for this change
What changes are included in this PR?
Implement decoder for FixedSizeList
Are these changes tested?
Yes
Are there any user-facing changes?
New decoding type supported